feat: add create retrieve and update api endpoints for organization resource #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-feature
jarnura
requested changes
Jul 18, 2024
…n-create-retrieve-update-endpoints
…n-create-retrieve-update-endpoints
…n-create-retrieve-update-endpoints
sahkal
reviewed
Jul 22, 2024
crates/hyperswitch_domain_models/src/payments/payment_attempt.rs
Outdated
Show resolved
Hide resolved
sahkal
previously approved these changes
Jul 22, 2024
lsampras
previously approved these changes
Jul 22, 2024
…n-create-retrieve-update-endpoints
| Self(organization_id) | ||
| } | ||
|
|
||
| /// Get the string representation of customer id |
There was a problem hiding this comment.
can you replace the instances of customer id with organization id?
There was a problem hiding this comment.
Will be done in this PR: #5380
Comment on lines
+3
to
+6
| #[cfg(all(any(feature = "v1", feature = "v2"), not(feature = "payment_v2")))] | ||
| use common_utils::types::keymanager::KeyManagerState; | ||
| #[cfg(all(feature = "v2", feature = "payment_v2"))] | ||
| use common_utils::types::keymanager::KeyManagerState; |
There was a problem hiding this comment.
is the feature gating required for this import? since we are using KeyManagerState in both the features
There was a problem hiding this comment.
cargo clippy --no-default-features will say unused imports.
Comment on lines
+1
to
+7
| #[cfg(all( | ||
| any(feature = "v1", feature = "v2"), | ||
| not(feature = "merchant_account_v2") | ||
| ))] | ||
| use common_utils::id_type; | ||
| #[cfg(all(feature = "v2", feature = "merchant_account_v2"))] | ||
| use common_utils::id_type; |
There was a problem hiding this comment.
we can use the type alias where the type is used, this feature gating for imports can be avoided
Narayanbhat166
approved these changes
Jul 23, 2024
jarnura
approved these changes
Jul 23, 2024
lsampras
approved these changes
Jul 24, 2024
pixincreate
deleted the
introduce-organization-create-retrieve-update-endpoints
branch
pixincreate
added a commit
that referenced
this pull request
Jul 24, 2024
* 'main' of github.com:juspay/hyperswitch: (27 commits) refactor(connector): added amount conversion framework for billwerk (#4972) feat(connector): [Itaubank] Add refund and rsync flow (#5420) feat: create additional columns in organization table (#5380) refactor(merchant_id): create domain type for `merchant_id` (#5408) fix(euclid): remove business_profile routing feature flag (#5430) feat: add create retrieve and update api endpoints for organization resource (#5361) chore(version): 2024.07.24.0 refactor(connector): [Itaubank] add dynamic fields for pix (#5419) Feat(connector): [WELLSFARGO] Add template code (#5333) fix(connector): [Datatrans] Handling for 4-Digit YYYY input and Correct 3DS Routing to no_3ds (#5410) refactor(connector): add amount conversion framework to volt (#4985) chore(users): email templates footer icon style enhance (#5375) feat(customer): customer v2 refactor for customer create end point (#5350) chore(version): 2024.07.23.0 fix(router): store `network_transaction_id` in stripe `authorize` flow (#5399) ci: handle packages to run are being empty (#5403) chore: add customer, shipping and billing details to payment_response for payment list api (#5401) refactor(dashboard_metadata): alter query for merchant scoped metadata (#5397) refactor(connector): Add billing_country in klarna dynamic fields (#5373) feat(connector): [Itau Bank] Add payment and sync flow for Pix (#5342) ...
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added
/organizationroute to do crud operation on organization table.Authentication method for
/organizationwill beadmin-api-keyAlso generated openapi spec for the new api models and endpoints.
New Routes:
create: POST->
{base_url}/organization/retrieve: Get->
{base_url}/organization/:idupdate: Put->
{base_url}/organization/:idAdditional Changes
Motivation and Context
How did you test it?
Manual
Response:
Response:
Response:
DB screenshot.
Checklist
cargo +nightly fmt --allcargo clippy